On Tue, 2025-07-22 at 01:13 -0600, Yangtao Li wrote: > [BUG] > $ sudo ./check generic/003 > FSTYP -- hfsplus > PLATFORM -- Linux/x86_64 graphic 6.8.0-58-generic #60~22.04.1- > Ubuntu > MKFS_OPTIONS -- /dev/loop29 > MOUNT_OPTIONS -- /dev/loop29 /mnt/scratch > > generic/003 - output mismatch > --- tests/generic/003.out 2025-04-27 08:49:39.876945323 -0600 > +++ /home/graphic/fs/xfstests-dev/results//generic/003.out.bad > > QA output created by 003 > +ERROR: change time has not been updated after changing file1 > Silence is golden > ... > > Ran: generic/003 > Failures: generic/003 > Failed 1 of 1 tests > > [CAUSE] > change time has not been updated after changing file1 > > [FIX] > Update file ctime after rename in hfsplus_rename(). > > Signed-off-by: Yangtao Li <frank.li@xxxxxxxx> > Tested-by: Viacheslav Dubeyko <slava@xxxxxxxxxxx> > Reviewed-by: Viacheslav Dubeyko <slava@xxxxxxxxxxx> > --- > fs/hfsplus/dir.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > Probably, it was not very good idea to combine the HFS+ patch with HFS patches, because I cannot take this one without others. :) Also, from my point of view, the patchset requires a cover letter. Otherwise, it looks slightly unusual. :) Thanks, Slava.
