From: Darrick J. Wong <djwong@xxxxxxxxxx> Teach the low level library about the iomap ioend handler, which gets called by the kernel when we finish a file write that isn't a pure overwrite operation. Signed-off-by: "Darrick J. Wong" <djwong@xxxxxxxxxx> --- include/fuse_common.h | 13 +++++++++++++ include/fuse_kernel.h | 12 ++++++++++++ include/fuse_lowlevel.h | 20 ++++++++++++++++++++ lib/fuse_lowlevel.c | 24 +++++++++++++++++++++++- 4 files changed, 68 insertions(+), 1 deletion(-) diff --git a/include/fuse_common.h b/include/fuse_common.h index f48724b0d1ea0f..66c25afe15ec76 100644 --- a/include/fuse_common.h +++ b/include/fuse_common.h @@ -1197,6 +1197,19 @@ struct fuse_iomap { uint16_t flags; /* FUSE_IOMAP_F_* */ uint32_t dev; /* device cookie */ }; + +/* out of place write extent */ +#define FUSE_IOMAP_IOEND_SHARED (1U << 0) +/* unwritten extent */ +#define FUSE_IOMAP_IOEND_UNWRITTEN (1U << 1) +/* don't merge into previous ioend */ +#define FUSE_IOMAP_IOEND_BOUNDARY (1U << 2) +/* is direct I/O */ +#define FUSE_IOMAP_IOEND_DIRECT (1U << 3) + +/* is append ioend */ +#define FUSE_IOMAP_IOEND_APPEND (1U << 15) + #endif /* FUSE_USE_VERSION >= 318 */ /* ----------------------------------------------------------- * diff --git a/include/fuse_kernel.h b/include/fuse_kernel.h index 97ca55f0114b1d..a06c16243a7885 100644 --- a/include/fuse_kernel.h +++ b/include/fuse_kernel.h @@ -666,6 +666,7 @@ enum fuse_opcode { FUSE_TMPFILE = 51, FUSE_STATX = 52, + FUSE_IOMAP_IOEND = 4093, FUSE_IOMAP_BEGIN = 4094, FUSE_IOMAP_END = 4095, @@ -1341,4 +1342,15 @@ struct fuse_iomap_end_in { uint32_t map_dev; /* device cookie */ }; +struct fuse_iomap_ioend_in { + uint16_t ioendflags; /* FUSE_IOMAP_IOEND_* */ + uint16_t reserved; /* zero */ + int32_t error; /* negative errno or 0 */ + uint64_t attr_ino; /* matches fuse_attr:ino */ + uint64_t pos; /* file position, in bytes */ + uint64_t new_addr; /* disk offset of new mapping, in bytes */ + uint32_t written; /* bytes processed */ + uint32_t reserved1; /* zero */ +}; + #endif /* _LINUX_FUSE_H */ diff --git a/include/fuse_lowlevel.h b/include/fuse_lowlevel.h index d3e505ed52815b..1b856431de0a60 100644 --- a/include/fuse_lowlevel.h +++ b/include/fuse_lowlevel.h @@ -1362,6 +1362,26 @@ struct fuse_lowlevel_ops { void (*iomap_end) (fuse_req_t req, fuse_ino_t nodeid, uint64_t attr_ino, off_t pos, uint64_t count, uint32_t opflags, ssize_t written, const struct fuse_iomap *iomap); + + /** + * Complete an iomap IO operation + * + * Valid replies: + * fuse_reply_err + * + * @param req request handle + * @param nodeid the inode number + * @param attr_ino inode number as told by fuse_attr::ino + * @param pos position in file, in bytes + * @param written number of bytes processed, or a negative errno + * @param ioendflags mask of FUSE_IOMAP_IOEND_ flags specifying operation + * @param error errno code of what went wrong + * @param new_addr disk address of new mapping, in bytes + */ + void (*iomap_ioend) (fuse_req_t req, fuse_ino_t nodeid, + uint64_t attr_ino, off_t pos, size_t written, + uint32_t ioendflags, int error, + uint64_t new_addr); #endif /* FUSE_USE_VERSION >= 318 */ }; diff --git a/lib/fuse_lowlevel.c b/lib/fuse_lowlevel.c index 5df0cdd4ac461a..d26043fa54c036 100644 --- a/lib/fuse_lowlevel.c +++ b/lib/fuse_lowlevel.c @@ -2515,6 +2515,27 @@ static void do_iomap_end(fuse_req_t req, const fuse_ino_t nodeid, _do_iomap_end(req, nodeid, inarg, NULL); } +static void _do_iomap_ioend(fuse_req_t req, const fuse_ino_t nodeid, + const void *op_in, const void *in_payload) +{ + const struct fuse_iomap_ioend_in *arg = op_in; + (void)in_payload; + (void)nodeid; + + if (req->se->op.iomap_ioend) + req->se->op.iomap_ioend(req, nodeid, arg->attr_ino, arg->pos, + arg->written, arg->ioendflags, + arg->error, arg->new_addr); + else + fuse_reply_err(req, 0); +} + +static void do_iomap_ioend(fuse_req_t req, const fuse_ino_t nodeid, + const void *inarg) +{ + _do_iomap_ioend(req, nodeid, inarg, NULL); +} + static bool want_flags_valid(uint64_t capable, uint64_t want) { uint64_t unknown_flags = want & (~capable); @@ -2713,7 +2734,6 @@ _do_init(fuse_req_t req, const fuse_ino_t nodeid, const void *op_in, se->conn.capable_ext |= FUSE_CAP_OVER_IO_URING; if (inargflags & FUSE_IOMAP) se->conn.capable_ext |= FUSE_CAP_IOMAP; - } else { se->conn.max_readahead = 0; } @@ -3395,6 +3415,7 @@ static struct { [FUSE_LSEEK] = { do_lseek, "LSEEK" }, [FUSE_IOMAP_BEGIN] = { do_iomap_begin, "IOMAP_BEGIN" }, [FUSE_IOMAP_END] = { do_iomap_end, "IOMAP_END" }, + [FUSE_IOMAP_IOEND] = { do_iomap_ioend, "IOMAP_IOEND" }, [CUSE_INIT] = { cuse_lowlevel_init, "CUSE_INIT" }, }; @@ -3451,6 +3472,7 @@ static struct { [FUSE_LSEEK] = { _do_lseek, "LSEEK" }, [FUSE_IOMAP_BEGIN] = { _do_iomap_begin, "IOMAP_BEGIN" }, [FUSE_IOMAP_END] = { _do_iomap_end, "IOMAP_END" }, + [FUSE_IOMAP_IOEND] = { _do_iomap_ioend, "IOMAP_IOEND" }, [CUSE_INIT] = { _cuse_lowlevel_init, "CUSE_INIT" }, };