On Mon, Jul 14, 2025 at 6:55 PM Andrew Price <anprice@xxxxxxxxxx> wrote:
> Clears up the warning added in 7ee3647243e5 ("migrate: Remove call to
> ->writepage") that occurs in various xfstests, causing "something found
> in dmesg" failures.
>
> [ 341.136573] gfs2_meta_aops does not implement migrate_folio
> [ 341.136953] WARNING: CPU: 1 PID: 36 at mm/migrate.c:944 move_to_new_folio+0x2f8/0x300
>
> Signed-off-by: Andrew Price <anprice@xxxxxxxxxx>
> ---
> fs/gfs2/meta_io.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
> index 9dc8885c95d07..66ee10929736f 100644
> --- a/fs/gfs2/meta_io.c
> +++ b/fs/gfs2/meta_io.c
> @@ -103,6 +103,7 @@ const struct address_space_operations gfs2_meta_aops = {
> .invalidate_folio = block_invalidate_folio,
> .writepages = gfs2_aspace_writepages,
> .release_folio = gfs2_release_folio,
> + .migrate_folio = buffer_migrate_folio_norefs,
> };
>
> const struct address_space_operations gfs2_rgrp_aops = {
> @@ -110,6 +111,7 @@ const struct address_space_operations gfs2_rgrp_aops = {
> .invalidate_folio = block_invalidate_folio,
> .writepages = gfs2_aspace_writepages,
> .release_folio = gfs2_release_folio,
> + .migrate_folio = buffer_migrate_folio_norefs,
> };
>
> /**
Thanks, I've added this to for-next.
Andreas
