On 2025/7/15 11:12, Zhang Yi wrote:
From: Zhang Yi <yi.zhang@xxxxxxxxxx>
Since both the input and output parameters of the
EXT4_MAX_PAGECACHE_ORDER should be unsigned int type, switch to using
umin() instead of min(). This will silence the compile error reported by
_compiletime_assert() on powerpc.
Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Closes: https://lore.kernel.org/all/20250715082230.7f5bcb1e@xxxxxxxxxxxxxxxx/
Signed-off-by: Zhang Yi <yi.zhang@xxxxxxxxxx>
Looks good. Feel free to add:
Reviewed-by: Baokun Li <libaokun1@xxxxxxxxxx>
---
fs/ext4/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 1bce9ebaedb7..6fd3692c4faf 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -5204,7 +5204,7 @@ static bool ext4_should_enable_large_folio(struct inode *inode)
* where the PAGE_SIZE exceeds 4KB.
*/
#define EXT4_MAX_PAGECACHE_ORDER(i) \
- min(MAX_PAGECACHE_ORDER, (11 + (i)->i_blkbits - PAGE_SHIFT))
+ umin(MAX_PAGECACHE_ORDER, (11 + (i)->i_blkbits - PAGE_SHIFT))
void ext4_set_inode_mapping_order(struct inode *inode)
{
if (!ext4_should_enable_large_folio(inode))
