On 7/13/25 10:31, Greg Kroah-Hartman wrote: > On Sat, Jul 12, 2025 at 08:26:17PM +0200, Daniel Gomez wrote: >> On 11/07/2025 16.05, Vlastimil Babka wrote: >> > Changes in v2: >> > - drop the patch to restrict module namespace export for in-tree modules >> > - fix a pre-existing documentation typo (Nicolas Schier) >> > - Link to v1: https://patch.msgid.link/20250708-export_modules-v1-0-fbf7a282d23f@xxxxxxx >> > --- >> > Documentation/core-api/symbol-namespaces.rst | 8 ++++---- >> > fs/anon_inodes.c | 2 +- >> > include/linux/export.h | 2 +- >> > 3 files changed, 6 insertions(+), 6 deletions(-) >> > >> > diff --git a/Documentation/core-api/symbol-namespaces.rst b/Documentation/core-api/symbol-namespaces.rst >> > index 32fc73dc5529e8844c2ce2580987155bcd13cd09..6f7f4f47d43cdeb3b5008c795d254ca2661d39a6 100644 >> > --- a/Documentation/core-api/symbol-namespaces.rst >> > +++ b/Documentation/core-api/symbol-namespaces.rst >> > @@ -76,8 +76,8 @@ A second option to define the default namespace is directly in the compilation >> > within the corresponding compilation unit before the #include for >> > <linux/export.h>. Typically it's placed before the first #include statement. >> > >> > -Using the EXPORT_SYMBOL_GPL_FOR_MODULES() macro >> > ------------------------------------------------ >> > +Using the EXPORT_SYMBOL_FOR_MODULES() macro >> > +------------------------------------------- >> > >> > Symbols exported using this macro are put into a module namespace. This >> > namespace cannot be imported. >> >> The new naming makes sense, but it breaks the pattern with _GPL suffix: >> >> * EXPORT_SYMBOL(sym) >> * EXPORT_SYMBOL_GPL(sym) >> * EXPORT_SYMBOL_NS(sym, ns) >> * EXPORT_SYMBOL_NS_GPL(sym, ns) >> * EXPORT_SYMBOL_FOR_MODULES(sym, mods) >> >> So I think when reading this one may forget about the _obvious_ reason. That's >> why I think clarifying that in the documentation would be great. Something like: >> >> Symbols exported using this macro are put into a module namespace. This >> namespace cannot be imported. And it's implicitly GPL-only as it's only intended >> for in-tree modules. > > s/implicitly/explicitly/
