Re: [PATCH] hfsplus: don't set REQ_SYNC for hfsplus_submit_bio()

[Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx>]

On Thu, 2025-07-10 at 08:35 +0200, Johannes Thumshirn wrote:
> hfsplus_submit_bio() called by hfsplus_sync_fs() uses bdev_virt_rw() which
> in turn uses submit_bio_wait() to submit the BIO.
> 
> But submit_bio_wait() already sets the REQ_SYNC flag on the BIO so there
> is no need for setting the flag in hfsplus_sync_fs() when calling
> hfsplus_submit_bio().
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
> ---
>  fs/hfsplus/super.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
> index 948b8aaee33e..8527e4ec406e 100644
> --- a/fs/hfsplus/super.c
> +++ b/fs/hfsplus/super.c
> @@ -222,8 +222,7 @@ static int hfsplus_sync_fs(struct super_block *sb, int wait)
>  
>  	error2 = hfsplus_submit_bio(sb,
>  				   sbi->part_start + HFSPLUS_VOLHEAD_SECTOR,
> -				   sbi->s_vhdr_buf, NULL, REQ_OP_WRITE |
> -				   REQ_SYNC);
> +				   sbi->s_vhdr_buf, NULL, REQ_OP_WRITE);
>  	if (!error)
>  		error = error2;
>  	if (!write_backup)
> @@ -231,8 +230,7 @@ static int hfsplus_sync_fs(struct super_block *sb, int wait)
>  
>  	error2 = hfsplus_submit_bio(sb,
>  				  sbi->part_start + sbi->sect_count - 2,
> -				  sbi->s_backup_vhdr_buf, NULL, REQ_OP_WRITE |
> -				  REQ_SYNC);
> +				  sbi->s_backup_vhdr_buf, NULL, REQ_OP_WRITE);
>  	if (!error)
>  		error2 = error;
>  out:

Looks good! Nice cleanup.

Reviewed-by: Viacheslav Dubeyko <slava@xxxxxxxxxxx>

Thanks,
Slava.