On Wed, 2025-07-09 at 07:37 +0000, Johannes Thumshirn wrote:
> On 08.07.25 22:10, Viacheslav Dubeyko wrote:
> > diff --git a/fs/hfs/bfind.c b/fs/hfs/bfind.c
> > index ef9498a6e88a..44a8b3ba4300 100644
> > --- a/fs/hfs/bfind.c
> > +++ b/fs/hfs/bfind.c
> > @@ -23,7 +23,7 @@ int hfs_find_init(struct hfs_btree *tree, struct hfs_find_data *fd)
> > return -ENOMEM;
> > fd->search_key = ptr;
> > fd->key = ptr + tree->max_key_len + 2;
> > - hfs_dbg(BNODE_REFS, "find_init: %d (%p)\n",
> > + hfs_dbg("find_init: %d (%p)\n",
> > tree->cnid, __builtin_return_address(0));
> > switch (tree->cnid) {
> > case HFS_CAT_CNID:
> > @@ -45,7 +45,7 @@ void hfs_find_exit(struct hfs_find_data *fd)
> > {
> > hfs_bnode_put(fd->bnode);
> > kfree(fd->search_key);
> > - hfs_dbg(BNODE_REFS, "find_exit: %d (%p)\n",
> > + hfs_dbg("find_exit: %d (%p)\n",
> > fd->tree->cnid, __builtin_return_address(0));
> > mutex_unlock(&fd->tree->tree_lock);
> > fd->tree = NULL;
>
> The function name prefix isn't needed either with dynamic debug.
>
> echo 'func hfs_find_exit +pf' > /proc/dynamic_debug/control
>
> will add it
Yeah, it's true. There are several other similar places.
I did small corrections there. But I agree that it makes sense to rework it.
Thanks,
Slava.
