Re: [PATCH 01/14] iomap: header diet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 08, 2025 at 03:51:07PM +0200, Christoph Hellwig wrote:
> Drop various unused #include statements.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Assuming the build bots don't hate this,
Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>

--D

> ---
>  fs/iomap/buffered-io.c | 10 ----------
>  fs/iomap/direct-io.c   |  5 -----
>  fs/iomap/fiemap.c      |  3 ---
>  fs/iomap/iter.c        |  1 -
>  fs/iomap/seek.c        |  4 ----
>  fs/iomap/swapfile.c    |  3 ---
>  fs/iomap/trace.c       |  1 -
>  7 files changed, 27 deletions(-)
> 
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index 3729391a18f3..addf6ed13061 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -3,18 +3,8 @@
>   * Copyright (C) 2010 Red Hat, Inc.
>   * Copyright (C) 2016-2023 Christoph Hellwig.
>   */
> -#include <linux/module.h>
> -#include <linux/compiler.h>
> -#include <linux/fs.h>
>  #include <linux/iomap.h>
> -#include <linux/pagemap.h>
> -#include <linux/uio.h>
>  #include <linux/buffer_head.h>
> -#include <linux/dax.h>
> -#include <linux/writeback.h>
> -#include <linux/swap.h>
> -#include <linux/bio.h>
> -#include <linux/sched/signal.h>
>  #include <linux/migrate.h>
>  #include "internal.h"
>  #include "trace.h"
> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
> index 844261a31156..6f25d4cfea9f 100644
> --- a/fs/iomap/direct-io.c
> +++ b/fs/iomap/direct-io.c
> @@ -3,14 +3,9 @@
>   * Copyright (C) 2010 Red Hat, Inc.
>   * Copyright (c) 2016-2025 Christoph Hellwig.
>   */
> -#include <linux/module.h>
> -#include <linux/compiler.h>
> -#include <linux/fs.h>
>  #include <linux/fscrypt.h>
>  #include <linux/pagemap.h>
>  #include <linux/iomap.h>
> -#include <linux/backing-dev.h>
> -#include <linux/uio.h>
>  #include <linux/task_io_accounting_ops.h>
>  #include "internal.h"
>  #include "trace.h"
> diff --git a/fs/iomap/fiemap.c b/fs/iomap/fiemap.c
> index 80675c42e94e..d11dadff8286 100644
> --- a/fs/iomap/fiemap.c
> +++ b/fs/iomap/fiemap.c
> @@ -2,9 +2,6 @@
>  /*
>   * Copyright (c) 2016-2021 Christoph Hellwig.
>   */
> -#include <linux/module.h>
> -#include <linux/compiler.h>
> -#include <linux/fs.h>
>  #include <linux/iomap.h>
>  #include <linux/fiemap.h>
>  #include <linux/pagemap.h>
> diff --git a/fs/iomap/iter.c b/fs/iomap/iter.c
> index 6ffc6a7b9ba5..cef77ca0c20b 100644
> --- a/fs/iomap/iter.c
> +++ b/fs/iomap/iter.c
> @@ -3,7 +3,6 @@
>   * Copyright (C) 2010 Red Hat, Inc.
>   * Copyright (c) 2016-2021 Christoph Hellwig.
>   */
> -#include <linux/fs.h>
>  #include <linux/iomap.h>
>  #include "trace.h"
>  
> diff --git a/fs/iomap/seek.c b/fs/iomap/seek.c
> index 04d7919636c1..56db2dd4b10d 100644
> --- a/fs/iomap/seek.c
> +++ b/fs/iomap/seek.c
> @@ -3,12 +3,8 @@
>   * Copyright (C) 2017 Red Hat, Inc.
>   * Copyright (c) 2018-2021 Christoph Hellwig.
>   */
> -#include <linux/module.h>
> -#include <linux/compiler.h>
> -#include <linux/fs.h>
>  #include <linux/iomap.h>
>  #include <linux/pagemap.h>
> -#include <linux/pagevec.h>
>  
>  static int iomap_seek_hole_iter(struct iomap_iter *iter,
>  		loff_t *hole_pos)
> diff --git a/fs/iomap/swapfile.c b/fs/iomap/swapfile.c
> index c1a762c10ce4..0db77c449467 100644
> --- a/fs/iomap/swapfile.c
> +++ b/fs/iomap/swapfile.c
> @@ -3,9 +3,6 @@
>   * Copyright (C) 2018 Oracle.  All Rights Reserved.
>   * Author: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>   */
> -#include <linux/module.h>
> -#include <linux/compiler.h>
> -#include <linux/fs.h>
>  #include <linux/iomap.h>
>  #include <linux/swap.h>
>  
> diff --git a/fs/iomap/trace.c b/fs/iomap/trace.c
> index 728d5443daf5..da217246b1a9 100644
> --- a/fs/iomap/trace.c
> +++ b/fs/iomap/trace.c
> @@ -3,7 +3,6 @@
>   * Copyright (c) 2019 Christoph Hellwig
>   */
>  #include <linux/iomap.h>
> -#include <linux/uio.h>
>  
>  /*
>   * We include this last to have the helpers above available for the trace
> -- 
> 2.47.2
> 
> 




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux