Re: [PATCH v3 20/21] __dentry_kill(): new locking scheme

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 7, 2025 at 10:59 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> Umm...  Note that further in that loop we'll be actively stealing the stuff from that
> shrink list that hasn't gotten to __dentry_kill().  Does your busy loop go into
> if (data.victim) after the second d_walk()?  IOW, does it manage to pull anything out
> of that shrink list?

No, I traced this, there is never a "data.victim" because none of the
dentries has DCACHE_SHRINK_LIST. "data.found" is only ever incremented
once (per loop iteration) because a "dead" lockref was found. The
second d_walk() doesn't find anything because it doesn't look for dead
(dying) dentries. You added that check only to the first call (only to
select_collect(), but not to select_collect2()).

I think we're getting closer to the point I was trying to make :-)





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux