RE: [PATCH] ceph: refactor wake_up_bit() pattern of calling

[Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx>]

On Mon, 2025-07-07 at 21:27 +0100, Matthew Wilcox wrote:
> On Mon, Jul 07, 2025 at 01:03:22PM -0700, Viacheslav Dubeyko wrote:
> >  	spin_lock(&dentry->d_lock);
> > -	di->flags &= ~CEPH_DENTRY_ASYNC_UNLINK;
> > +	clear_bit(CEPH_DENTRY_ASYNC_UNLINK_BIT, &di->flags);
> > +	/* ensure modified bit is visible */
> > +	smp_mb__after_atomic();
> >  	wake_up_bit(&di->flags, CEPH_DENTRY_ASYNC_UNLINK_BIT);
> 
> Seems like you're open-coding clear_and_wake_up_bit()?

Damn, we already have this primitive. :) Makes sense to rework the patch.

Thanks,
Slava.