Re: [PATCH] hfsplus: don't use BUG_ON() in hfsplus_create_attributes_file()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2025/07/07 23:22, Yangtao Li wrote:
> 161         case HFSPLUS_VALID_ATTR_TREE:
> 162                 return 0;
> 163         case HFSPLUS_FAILED_ATTR_TREE:
> 164                 return -EOPNOTSUPP;
> 165         default:
> 166                 BUG();
> 167         }
> 
> I haven't delved into the implementation details of xattr yet, but
> there is a bug in this function. It seems that we should convert
> the bug to return EIO in another patch?

I don't think this BUG() is triggerable. attr_tree_state is an atomic_t
which can take only one of HFSPLUS_EMPTY_ATTR_TREE, HFSPLUS_VALID_ATTR_TREE,
HFSPLUS_FAILED_ATTR_TREE or HFSPLUS_CREATING_ATTR_TREE.





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux