Re: [PATCH] mm, vmstat: remove the NR_WRITEBACK_TEMP node_stat_item counter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/25/25 17:51, Vlastimil Babka wrote:
> The only user of the counter (FUSE) was removed in commit 0c58a97f919c
> ("fuse: remove tmp folio for writebacks and internal rb tree") so follow
> the established pattern of removing the counter and hardcoding 0 in
> meminfo output, as done recently with NR_BOUNCE. Update documentation
> for procfs, including for the value for Bounce that was missed when
> removing its counter.
> 
> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>
> ---
> The removal of the counter is straightforward. The reason for the large
> Cc list is that there is a comment in mm/page-writeback.c function
> wb_position_ratio() that mentions NR_WRITEBACK_TEMP, and just deleting
> the sentence feels to me it could be the wrong thing to do - maybe the
> strictlimit feature itself is now obsolete? It sure does mention FUSE
> as the main reason to exist, but commit 5a53748568f79 that introduced it
> also mentions slow USB sticks as a possibile scenario. Has that
> happened? I'm not familiar enough with this so I'd rather highlight this
> and ask for input here than make "git grep NR_WRITEBACK_TEMP" return
> nothing.

Thanks all for the input. Andrew, please squash in this fixup. The changelog
of that can be appended to the changelog of the original patch. Thanks.

----8<----

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux