On Mon, Jul 07, 2025 at 11:55:39AM +0200, Jan Polensky wrote:
> Hi all,
>
> While testing the latest linux-next kernel (next-20250704), I encountered a
> reproducible issue during LTP (Linux Test Project) runs related to signal
> handling and core dumps.
>
> The issue appears to be introduced by commit:
>
> ef4744dc9960 ("coredump: split pipe coredumping into coredump_pipe()")
>
> This commit seems to contain a typo or logic error that causes several LTP tests
> to fail due to missing or incorrect core dump behavior.
>
> ### Affected LTP tests and output:
>
> - abort01:
> abort01.c:58: TFAIL: abort() failed to dump core
>
> - kill11:
> kill11.c:84: TFAIL: core dump bit not set for SIGQUIT
> kill11.c:84: TFAIL: core dump bit not set for SIGILL
> kill11.c:84: TFAIL: core dump bit not set for SIGTRAP
> kill11.c:84: TFAIL: core dump bit not set for SIGIOT/SIGABRT
> kill11.c:84: TFAIL: core dump bit not set for SIGBUS
> kill11.c:84: TFAIL: core dump bit not set for SIGFPE
> kill11.c:84: TFAIL: core dump bit not set for SIGSEGV
> kill11.c:84: TFAIL: core dump bit not set for SIGXCPU
> kill11.c:84: TFAIL: core dump bit not set for SIGXFSZ
> kill11.c:84: TFAIL: core dump bit not set for SIGSYS/SIGUNUSED
>
> - waitpid01:
> waitpid01.c:140: TFAIL: Child did not dump core when expected
>
> Best regards,
> Jan
>
> Signed-off-by: Jan Polensky <japo@xxxxxxxxxxxxx>
> ---
Very odd because I run the coredump tests. Can you please give me the
exact LTP command so I can make sure I'm running those tests?
> Only a suggestion for a fix:
> fs/coredump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/coredump.c b/fs/coredump.c
> index 081b5e9d16e2..f4f7f0a0ae40 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -1019,7 +1019,7 @@ static bool coredump_pipe(struct core_name *cn, struct coredump_params *cprm,
> if (!sub_info)
> return false;
>
> - if (!call_usermodehelper_exec(sub_info, UMH_WAIT_EXEC)) {
> + if (call_usermodehelper_exec(sub_info, UMH_WAIT_EXEC)) {
> coredump_report_failure("|%s pipe failed", cn->corename);
> return false;
> }
> --
> 2.48.1
>
