On Fri, Jun 20, 2025 at 04:12:35PM +0200, Oscar Salvador wrote: > On Tue, Jun 17, 2025 at 05:43:35PM +0200, David Hildenbrand wrote: > > Let's clean it all further up. > > > > Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> > > Reviewed-by: Oscar Salvador <osalvador@xxxxxxx> > > I was thinking maybe we want to pass 'struct vm_fault' directly to insert_pmd(), > and retrieve the fields in there, but since you have to retrieve some in > insert_pfn_pmd().. maybe not. Where practical I quite like having callers retrieve context struct fields rather than passing the whole struct down. It makes it very obvious what elements insert_pmd() cares about (in this case one of about fourteen fields). Anyway looks good, thanks: Reviewed-by: Alistair Popple <apopple@xxxxxxxxxx> > -- > Oscar Salvador > SUSE Labs
