On 7/2/25 6:23 PM, Al Viro wrote: > On Wed, Jul 02, 2025 at 05:19:12PM -0600, Jens Axboe wrote: >> >> On Wed, 02 Jul 2025 22:14:08 +0100, Al Viro wrote: >>> When debugfs file has been created by debugfs_create_file_unsafe(), >>> we do need the file_operations methods to use debugfs_file_{get,put}() >>> to prevent concurrent removal; for files created by debugfs_create_file() >>> that is done in the wrappers that call underlying methods, so there's >>> no point whatsoever duplicating that in the underlying methods themselves. >>> >>> >>> [...] >> >> Applied, thanks! >> >> [10/11] blk-mq-debugfs: use debugfs_get_aux() >> commit: c25885fc939f29200cccb58ffdb920a91ec62647 > > Umm... That sucker depends upon the previous commit - you'll > need to cast debugfs_get_aux() result to void * without that... Gah ok - wasn't cleear since I wasn't CC'ed on the series, just the single patch. If it's a single patch, I'm assuming it's good to go if it looks good. I'll just drop it. -- Jens Axboe