On Tue 01-07-25 21:06:26, Zhang Yi wrote: > From: Zhang Yi <yi.zhang@xxxxxxxxxx> > > Since ext4 supports large folios, processing writebacks in pages is no > longer appropriate, it can be modified to process writebacks in bytes. > > Suggested-by: Jan Kara <jack@xxxxxxx> > Signed-off-by: Zhang Yi <yi.zhang@xxxxxxxxxx> Just one small issue. With that fixed feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> > @@ -2786,18 +2788,18 @@ static int ext4_do_writepages(struct mpage_da_data *mpd) > writeback_index = mapping->writeback_index; > if (writeback_index) > cycled = 0; > - mpd->first_page = writeback_index; > - mpd->last_page = -1; > + mpd->start_pos = writeback_index << PAGE_SHIFT; > + mpd->end_pos = -1; Careful here. Previously last_page was unsigned long so -1 was fine but now loff_t is signed. So we should rather store LLONG_MAX here. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
