Re: [PATCH v1 20/29] mm: convert "movable" flag in page->mapping to a page flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 30, 2025 at 03:00:01PM +0200, David Hildenbrand wrote:
> Instead, let's use a page flag. As the page flag can result in
> false-positives, glue it to the page types for which we
> support/implement movable_ops page migration.
> 
> The flag reused by PageMovableOps() might be sued by other pages, so
> warning in case it is set in page_has_movable_ops() might result in
> false-positive warnings.
> 
> Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
> ---

LGTM,
Reviewed-by: Harry Yoo <harry.yoo@xxxxxxxxxx>

With a question: is there any reason to change the page flag
operations to use atomic bit ops? (.e.g, using SetPageMovableOps instead
of __SetPageMovableOps)

-- 
Cheers,
Harry / Hyeonggon




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux