Re: [PATCH] fuse: return -EOPNOTSUPP from ->fileattr_[gs]et() instead of -ENOTTY

[Amir Goldstein <amir73il@xxxxxxxxx>]

On Tue, Jul 1, 2025 at 7:41 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>
> On Tue, 1 Jul 2025 at 16:29, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>
> > index 6f0e15f86c21..92754749f316 100644
> > --- a/fs/overlayfs/inode.c
> > +++ b/fs/overlayfs/inode.c
> > @@ -722,7 +722,7 @@ int ovl_real_fileattr_get(const struct path *realpath, struct fileattr *fa)
> >
> >         err = vfs_fileattr_get(realpath->dentry, fa);
> >         if (err == -ENOIOCTLCMD)
> > -               err = -ENOTTY;
> > +               err = -EOPNOTSUPP;
>
> This doesn't make sense, the Andrey's 4/6 patch made vfs_fileattr_get
> return EOPNOTSUPP instead of ENOIOCTLCMD.  So why is it being checked
> here?

You are right.
I was trying to demonstrate the change in fuse/ovl independent of
Ansrey's patch, but don't worry after squashing this patch,
there is no remaining conversion in ovl_real_fileattr_get().

I verified that with Christian.

Thanks,
Amir.