On Tue, Jul 1, 2025 at 6:27 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
>
> Add `Guard::{insert,reserve}` and `Guard::{insert,reserve}_limit`, which
> are akin to `__xa_{alloc,insert}` in C.
Who will be using this? i.e. we need to justify adding code, typically
by mentioning the users.
By the way, it may help splitting the C parts into its own patch, so
that Matthew can focus on that (but maybe you all already discussed
this).
Also, unit tests are great, thanks for adding those. Can we add
examples as well? Maybe on the module-level docs, given the rest are
there.
> + /// Wrapper around `__xa_alloc`.
We try to mention what something does in the title at least, even if
it is just copied from the C docs -- you can reference those docs too
for more context, e.g. [`__xa_alloc`] to:
https://docs.kernel.org/core-api/xarray.html#c.__xa_alloc
Cheers,
Miguel
