On Fri, Jun 27, 2025 at 10:46:04AM -0400, Josef Bacik wrote: > On Thu, Jun 26, 2025 at 10:22:52PM -0400, Kent Overstreet wrote: > > per the maintainer thread discussion and precedent in xfs and btrfs > > for repair code in RCs, journal_rewind is again included > > I'm replying to set the record straight. This is not the start of the > discussion. I am not going to let false statements stand by unchallenged > however. > > Sterba has never sent large pull requests in RCs, certainly not with > features in them. Even when Chris was the maintainer and we were a > little faster and looser and were pushing the envelope to see what > Linus would accept we didn't ship anything near this volume of > patches past rc1. And as far as XFS is concerned, "citation needed". Dave Chinner (who is not the current XFS maintainer) has asserted that there might be a time when XFS *might* want to send repair code post merge window. However, I'm not aware of any time when Darrick Wong was working on XFS online repair that he sent changes outside of the merge window as the XFS maintainer. And now that XFS online repair feature is upstream, *bug fixes* can be sent at any time. So (a) I am not aware of any time that XFS *has* sent online repair changes upstream outside of a merge window --- this is just an assertion by Kent --- and (b) I am not sure when XFS would need to send some kind of new feature involving online repair upstream, given that online repair is *already* upstream. - Ted
