On Wed 25-06-25 12:53:54, Pankaj Raghav (Samsung) wrote:
> On Wed, Jun 25, 2025 at 12:16:49PM +0200, Jan Kara wrote:
> > On Wed 25-06-25 10:37:04, Pankaj Raghav wrote:
> > > All filesystems will already check the max and min value of their block
> > > size during their initialization. __getblk_slow() is a very low-level
> > > function to have these checks. Remove them and only check for logical
> > > block size alignment.
> > >
> > > Suggested-by: Matthew Wilcox <willy@xxxxxxxxxxxxx>
> > > Signed-off-by: Pankaj Raghav <p.raghav@xxxxxxxxxxx>
> >
> > I know this is a bikeshedding but FWIW this is in the should never trigger
> > territory so I'd be inclined to just make it WARN_ON_ONCE() and completely
> > delete it once we refactor bh apis to make sure nobody can call bh
> > functions with anything else than sb->s_blocksize.
> >
> Something like this:
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index a1aa01ebc0ce..a49b4be37c62 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -1122,10 +1122,9 @@ __getblk_slow(struct block_device *bdev, sector_t block,
> {
> bool blocking = gfpflags_allow_blocking(gfp);
>
> - if (unlikely(size & (bdev_logical_block_size(bdev) - 1))) {
> + if (WARN_ON_ONCE(size & (bdev_logical_block_size(bdev) - 1))) {
> printk(KERN_ERR "getblk(): block size %d not aligned to logical block size %d\n",
> size, bdev_logical_block_size(bdev));
> - dump_stack();
> return NULL;
> }
>
> I assume we don't need the dump_stack() anymore as we will print them
> with WARN_ON_ONCE anyway?
Correct. Thanks! Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
