On Wed, 2025-06-25 at 00:01 -0700, Christoph Hellwig wrote: > On Wed, Jun 25, 2025 at 10:44:57AM +0800, Yafang Shao wrote: > > > That's really kernel wide policy and not something magic done by a > > > single file system. > > > > XFS already supports an optional policy for handling metadata errors via: > > /sys/fs/xfs/<disk>/error/metadata/ > > > > It would be reasonable to introduce a similar optional policy for data > > errors: > > /sys/fs/xfs/<disk>/error/data/ > > > > This data error policy could allow the filesystem to shut down immediately > > if corrupted data is detected that might otherwise be exposed to userspace. > > I fully agree on that part, and would in fact argue for making it the > default. > > But reporting writeback errors on read just on one file system and with > a specific option is really strange. Another option: We could expose this functionality in preadv2() with a new RWF_WBERR flag (better names welcome). That way applications could opt-in to checking for writeback errors like this. With that, the application is at least explicitly saying that it wants this behavior. -- Jeff Layton <jlayton@xxxxxxxxxx>
