On 25.06.25 11:20, Oscar Salvador wrote:
On Wed, Jun 25, 2025 at 10:57:39AM +0200, David Hildenbrand wrote:
I don't think that comment is required anymore -- we do exactly what
vm_normal_page() does + documents,
What the current users are is not particularly important anymore.
Or why do you think it would still be important?
Maybe the current users are not important, but at least a comment directing
to vm_normal_page like "See comment in vm_normal_page".
Here, and in vm_normal_page_pud().
Just someone has it clear why we're only checking for X and Y when we find a
pte/pmd/pud special.
But not really a strong opinion here, just I think that it might be helpful.
I was already debating with myself whether to add full kerneldoc for
these functions ... but yeah, to me the link to "vm_normal_page()" is
obvious, but we can just spell it out "see vm_normal_page()".
--
Cheers,
David / dhildenb
