On Tue, Jun 17, 2025 at 05:43:45PM +0200, David Hildenbrand wrote:
> ... and hide it behind a kconfig option. There is really no need for
> any !xen code to perform this check.
>
> The naming is a bit off: we want to find the "normal" page when a PTE
> was marked "special". So it's really not "finding a special" page.
>
> Improve the documentation, and add a comment in the code where XEN ends
> up performing the pte_mkspecial() through a hypercall. More details can
> be found in commit 923b2919e2c3 ("xen/gntdev: mark userspace PTEs as
> special on x86 PV guests").
Looks good to me.
Since this seems a "mistake" from the past we don't want to repeat, I wonder
whether we could seal FIND_NORMAL_PAGE somehow, and scream if someone
tries to enable it on !XEN environments.
--
Oscar Salvador
SUSE Labs
