On Mon, Jun 23, 2025 at 10:36:45PM +0800, Baoquan He wrote: > On 06/23/25 at 06:47pm, Su Hui wrote: > > There are three cleanups for vmcore_add_device_dump(). Adjust data_size's > > type from 'size_t' to 'unsigned int' for the consistency of data->size. > > It's unclear to me why size_t is not suggested here. Isn't it assigned > a 'sizeof() + data->size' in which size_t should be used? Yeah... That's a good point. People should generally default to size_t for sizes. It really does prevent a lot of integer overflow bugs. In this case data->size is not controlled by the user, but if it were then that would be an integer overflow on 32bit systems and not on 64bit systems, until we start declaring sizes as unsigned int and then all the 32bit bugs start affecting everyone. regards, dan carpenter
