On Thu, Jun 19, 2025 at 02:12:49PM +0200, Oscar Salvador wrote: > On Wed, Jun 18, 2025 at 08:42:52PM +0100, Lorenzo Stoakes wrote: > > We abstract the type of the VMA flags to vm_flags_t, however in may places > many? > > it is simply assumed this is unsigned long, which is simply incorrect. > > > > At the moment this is simply an incongruity, however in future we plan to > > change this type and therefore this change is a critical requirement for > > doing so. > > > > Overall, this patch does not introduce any functional change. > > > > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> > > Reviewed-by: Oscar Salvador <osalvador@xxxxxxx> > > Same comments as Vlastimil, you want to push vmflag_to_pte_pkey_bits > further to patch#2 and bring As I said to him, this is invoked by vm_get_page_prot() so has to be updated too as a consequence, so it belongs here imo. Also to be (extremely) pedantic if we were to push it it would be to patch 3/3 :P > > arch/powerpc/mm/book3s64/pgtable.c:pgprot_t vm_get_page_prot(unsigned long vm_flags) Yeah I checked so much and of course, of course... :P > > > -- > Oscar Salvador > SUSE Labs
