Re: [PATCH 6/6] iomap: move all ioend handling to ioend.c

[Joanne Koong <joannelkoong@xxxxxxxxx>]

On Mon, Jun 16, 2025 at 6:00 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> Now that the writeback code has the proper abstractions, all the ioend
> code can be self-contained in iomap.c.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  fs/iomap/buffered-io.c | 215 ----------------------------------------
>  fs/iomap/internal.h    |   1 -
>  fs/iomap/ioend.c       | 220 ++++++++++++++++++++++++++++++++++++++++-
>  3 files changed, 219 insertions(+), 217 deletions(-)
> diff --git a/fs/iomap/internal.h b/fs/iomap/internal.h
> index f6992a3bf66a..d05cb3aed96e 100644
> --- a/fs/iomap/internal.h
> +++ b/fs/iomap/internal.h
> @@ -4,7 +4,6 @@
>
>  #define IOEND_BATCH_SIZE       4096
>
> -u32 iomap_finish_ioend_buffered(struct iomap_ioend *ioend);
>  u32 iomap_finish_ioend_direct(struct iomap_ioend *ioend);
>

Should iomap_finish_ioend_direct() get moved to ioend.c as well?