On Wed 11-06-25 09:40:44, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> This function takes super_lock in shared mode, so it should release the
> same lock.
>
> Cc: <stable@xxxxxxxxxxxxxxx> # v6.16-rc1
> Fixes: af7551cf13cf7f ("super: remove pointless s_root checks")
> Signed-off-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>
Indeed that was an oversight. Thanks for catching it! Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/super.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/super.c b/fs/super.c
> index 21799e213fd747..80418ca8e215bb 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -964,8 +964,10 @@ void iterate_supers_type(struct file_system_type *type,
> spin_unlock(&sb_lock);
>
> locked = super_lock_shared(sb);
> - if (locked)
> + if (locked) {
> f(sb, arg);
> + super_unlock_shared(sb);
> + }
>
> spin_lock(&sb_lock);
> if (p)
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
