On Tue, Jun 10, 2025 at 09:21:37AM +0100, Al Viro wrote: > mnt_set_mountpoint_beneath() consists of attaching new mount side-by-side > with the one we want to mount beneath (by mnt_set_mountpoint()), followed > by mnt_change_mountpoint() shifting the the top mount onto the new one > (by mnt_change_mountpoint()). > > Both callers of mnt_set_mountpoint_beneath (both in attach_recursive_mnt()) > have the same form - in 'beneath' case we call mnt_set_mountpoint_beneath(), > otherwise - mnt_set_mountpoint(). > > The thing is, expressing that as unconditional mnt_set_mountpoint(), > followed, in 'beneath' case, by mnt_change_mountpoint() is just as easy. > And these mnt_change_mountpoint() callers are similar to the ones we > do when it comes to attaching propagated copies, which will allow more > cleanups in the next commits. > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > --- Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>
