On Tue, Jun 10, 2025 at 06:52:53PM +0530, Anuj Gupta wrote: > + switch (bi->csum_type) { > + case BLK_INTEGRITY_CSUM_NONE: > + if (!bi->pi_size) { > + pr_warn("pi_size must be 0 when checksum type \ > + is none\n"); Based on the message and how the code should work I think the test above is inverted. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>