Re: [PATCH v4 4/7] cxl/acpi: Add background worker to wait for cxl_pci and cxl_mem probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dave Jiang <dave.jiang@xxxxxxxxx>, Smita Koralahalli <Smita.KoralahalliChannabasappa@xxxxxxx>, "linux-cxl@xxxxxxxxxxxxxxx" <linux-cxl@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "nvdimm@xxxxxxxxxxxxxxx" <nvdimm@xxxxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "linux-pm@xxxxxxxxxxxxxxx" <linux-pm@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v4 4/7] cxl/acpi: Add background worker to wait for cxl_pci and cxl_mem probe
From: "Zhijian Li (Fujitsu)" <lizhijian@xxxxxxxxxxx>
Date: Thu, 5 Jun 2025 02:18:22 +0000
Accept-language: en-US, zh-CN
Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx>, Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>, Alison Schofield <alison.schofield@xxxxxxxxx>, Vishal Verma <vishal.l.verma@xxxxxxxxx>, Ira Weiny <ira.weiny@xxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, "Rafael J . Wysocki" <rafael@xxxxxxxxxx>, Len Brown <len.brown@xxxxxxxxx>, Pavel Machek <pavel@xxxxxxxxxx>, Li Ming <ming.li@xxxxxxxxxxxx>, Jeff Johnson <jeff.johnson@xxxxxxxxxxxxxxxx>, Ying Huang <huang.ying.caritas@xxxxxxxxx>, "Xingtao Yao (Fujitsu)" <yaoxt.fnst@xxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>, Nathan Fontenot <nathan.fontenot@xxxxxxx>, Terry Bowman <terry.bowman@xxxxxxx>, Robert Richter <rrichter@xxxxxxx>, Benjamin Cheatham <benjamin.cheatham@xxxxxxx>, PradeepVineshReddy Kodamati <PradeepVineshReddy.Kodamati@xxxxxxx>
In-reply-to: <acb0f359-cd4a-4221-a7ba-9c473ad7ecd2@intel.com>
Thread-index: AQHb1NWwFxOtCct2okebJfTHnbLTZbPyv7mAgABSdoCAAMRbAA==
Thread-topic: [PATCH v4 4/7] cxl/acpi: Add background worker to wait for cxl_pci and cxl_mem probe
User-agent: Mozilla Thunderbird


On 04/06/2025 22:35, Dave Jiang wrote:
>>>    
>>> +static DECLARE_WAIT_QUEUE_HEAD(cxl_wait_queue);
>> Given that this file (suspend.c) focuses on power management functions,
>> it might be more appropriate to move the wait queue declaration and its
>> related changes to acpi.c in where the its caller is.
> You mean drivers/cxl/acpi.c and not drivers/cxl/core/acpi.c right? 

Yes


> The core one is my mistake and I'm going to create a patch to remove that.


Completely missed its existence - thank you for catching and cleaning that up!

Thanks
Zhijian


> 
> DJ

References:
- [PATCH v4 0/7] Add managed SOFT RESERVE resource handling
  - From: Smita Koralahalli
- [PATCH v4 4/7] cxl/acpi: Add background worker to wait for cxl_pci and cxl_mem probe
  - From: Smita Koralahalli
- Re: [PATCH v4 4/7] cxl/acpi: Add background worker to wait for cxl_pci and cxl_mem probe
  - From: Zhijian Li (Fujitsu)
- Re: [PATCH v4 4/7] cxl/acpi: Add background worker to wait for cxl_pci and cxl_mem probe
  - From: Dave Jiang

Prev by Date: Re: [QUESTION] xfs, iomap: Handle writeback errors to prevent silent data corruption
Next by Date: Re: [PATCH 07/12] mm: Remove redundant pXd_devmap calls
Previous by thread: Re: [PATCH v4 4/7] cxl/acpi: Add background worker to wait for cxl_pci and cxl_mem probe
Next by thread: [PATCH v4 5/7] cxl/region: Introduce SOFT RESERVED resource removal on region teardown
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]