On 6/3/2025 10:22 AM, Christoph Hellwig wrote:
> On Mon, Jun 02, 2025 at 12:17:54PM -0700, Ackerley Tng wrote:
>> +struct inode *alloc_anon_secure_inode(struct super_block *s, const char *name)
>> +{
>> + return anon_inode_make_secure_inode(s, name, NULL, true);
>> +}
>> +EXPORT_SYMBOL_GPL(alloc_anon_secure_inode);
>
> What is "secure" about this inode?
>
> A kerneldoc explaining that would probably help.
>
Hi Ackerley,
I had been working on the same based on David's suggestion and included kernel-doc
for the new functions.
https://lore.kernel.org/linux-mm/fc6b74e1-cbe4-4871-89d4-3855ca8f576b@xxxxxxx
Feel free to incorporate the documentation from my patches,
Happy to send it as a follow-up patch or you can grab it from my earlier version.
Thanks,
Shivank
>> +extern struct inode *alloc_anon_secure_inode(struct super_block *, const char *);
>
> No need for the extern here. Spelling out the parameter names in
> protypes is nice, though. (and fix the long line while you're at it).
>
>
