Re: [PATCH] fuse: add max_stack_depth to fuse_init_in

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi,

Sorry for being so late to reply to this: it's been busy.

On Fri, 16 May 2025 at 11:07, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
> Okay, let's add it to fuse_init_in as uint8_t.

Is this to help save a few bytes?  I'm not sure it's worth it, for a
few reasons:
 - there are 11 reserved fields here, which is still quite a lot of room
 - even if we reduce this to a single byte, we need to add 3 extra
bytes of padding, which is a bit awkward.  We also only get to use
this if we have something else that fits into a u8 or u16, otherwise
it's wasted
 - we might imagine some sort of a beautiful future where the kernel
figures out a way to increase this restriction considerably (ie: >
256).  I'm not sure how that would look, but it seems foolish to not
consider it.

I'm happy to redo the patch if you're sure this is right (since I want
to update the commit message a bit anyway), but how should I call the
3 extra bytes in that case?  unused2?  reserved?

Thanks

lis





[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux