On Sun, 25 May 2025 at 13:48, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> I wonder if we shouldn't do ...
>
> +++ b/include/linux/fs.h
> @@ -3725,6 +3725,8 @@ static inline int kiocb_set_rw_flags(struct kiocb *ki, rwf_t flags,
> return -EOPNOTSUPP;
> }
> if (flags & RWF_DONTCACHE) {
> + /* Houston, we have a problem */
> + return -EOPNOTSUPP;
Hmm. Your point about other filesystems is well taken.
I'd have preferred a revert as a "don't do anything new at this
point", but I guess disabling it at this point is probably the safer
option considering that this isn't a xfs issue.
> Oh, and we're only just seeing it, I think, because you need to recompile
> xfstests to test this functionality ...
Ahh, good. Well, not "good" exactly, but it certainly at least
explains the unlucky timing.
Thanks,
Linus
