On Thu, May 22, 2025 at 12:30 AM John Groves <John@xxxxxxxxxx> wrote: > > On 25/04/20 08:33PM, John Groves wrote: > > Subject: famfs: port into fuse > > > > <snip> > > I'm planning to apply the review comments and send v2 of > this patch series soon - hopefully next week. > > I asked a couple of specific questions for Miklos and > Amir at [1] that I hope they will answer in the next few > days. I missed this question. Feel free to ping me next time if I am not answering. > Do you object to zeroing fuse_inodes when they're > allocated, and do I really need an xchg() to set the > fi->famfs_meta pointer during fuse_alloc_inode()? cmpxchg > would be good for avoiding stepping on an "already set" > pointer, but not useful if fi->famfs_meta has random > contents (which it does when allocated). > I don't have anything against zeroing the fuse inode fields but be careful not to step over fuse_inode_init_once(). The answer to the xchg() question is quite technically boring. At least in my case it was done to avoid an #ifdef in c file. Thanks, Amir.
