Re: [PATCH v6 01/11] fuse: support copying large folios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 15 May 2025 at 19:54, Joanne Koong <joannelkoong@xxxxxxxxx> wrote:

> I think this needs to be:
>
>                 if (folio) {
>                         void *mapaddr = kmap_local_folio(folio, offset);
>                         void *buf = mapaddr;
>                         unsigned copy = count;
>                         unsigned bytes_copied;
>
>                         if (folio_test_highmem(folio) && count >
> PAGE_SIZE - offset_in_page(offset))
>                                 copy = PAGE_SIZE - offset_in_page(offset);
>
>                         bytes_copied = fuse_copy_do(cs, &buf, &copy);
>                         kunmap_local(mapaddr);
>                         offset += bytes_copied;
>                         count -= bytes_copied;
>
> else it will only copy the first page of the highmem folio.

Right.  Fix applied.

Thanks,
Miklos




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux