On Tue, 13 May 2025 at 22:39, Joanne Koong <joannelkoong@xxxxxxxxx> wrote: > > On Tue, May 13, 2025 at 12:19 AM Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > > > On Tue, 13 May 2025 at 00:59, Joanne Koong <joannelkoong@xxxxxxxxx> wrote: > > > > > > Optimize processing folios larger than one page size for the direct io > > > case. If contiguous pages are part of the same folio, collate the > > > processing instead of processing each page in the folio separately. > > > > This patch is sort of special in the series, since the others are > > basically no-op until large folios are enabled. > > > > Did you validate this in particular? Is there a good way to test > > direct I/O on a buffer with mixed folio sizes? > > Hi Miklos, > > No, I did not validate this case in particular. I'm happy to drop this > patch for now and resend it when large folios get turned on, if you > prefer that. It seems like it'd be good to add this case to xfstests. Dropped for now. Thanks, Miklos