On Fri, May 09, 2025 at 03:32:32PM +0200, Amir Goldstein wrote:
> Christian,
>
> This adds a test for fanotify mount ns notifications inside userns [1].
>
> While working on the test I ended up making lots of cleanups to reduce
> build dependency on make headers_install.
>
> These patches got rid of the dependency for my kvm setup for the
> affected filesystems tests.
>
> Building with TOOLS_INCLUDES dir was recommended by John Hubbard [2].
>
> NOTE #1: these patches are based on a merge of vfs-6.16.mount
> (changes wrappers.h) into v6.15-rc5 (changes mount-notify_test.c),
> so if this cleanup is acceptable, we should probably setup a selftests
> branch for 6.16, so that it can be used to test the fanotify patches.
>
> NOTE #2: some of the defines in wrappers.h are left for overlayfs and
> mount_setattr tests, which were not converted to use TOOLS_INCLUDES.
> I did not want to mess with those tests.
So I added both wrappers.h and utils.{c,h} and I had always intended to
make them more widely available since quite a few things use them by now
and I'm probably the cuplrit here. :) So thanks for this work!
As a next step we should move all VFS/FS related tests from selftests/
into selftests/filesystems/. So if anyone has the time and energy for
this I will very very happily merge this.
