On 5/8/25 4:44 AM, Amir Goldstein wrote: > On Thu, May 8, 2025 at 9:43 AM John Hubbard <jhubbard@xxxxxxxxxx> wrote: >> On 5/7/25 1:43 PM, Amir Goldstein wrote: ... >>> CFLAGS += -Wall -O2 -g $(KHDR_INCLUDES) $(TOOLS_INCLUDES) >>> +LDLIBS += -lcap >> >> This addition of -lcap goes completely unmentioned in the commit log. >> I'm guessing you are fixing things up to build, so this definitely >> deserves an explanation there. >> > > This is needed because we are linking with utils.c code. > See below. I'll look into this. > I guess we could have built a filesystems selftests utils library, > but that seems like an operkill? Definitely maximum overkill, and that's not where I was going, agreed. :) Below... ... >>> +$(OUTPUT)/statmount_test_ns: ../utils.c >> >> This is surprising: a new Makefile target, without removing an old one. >> And it's still listed in TEST_GEN_PROGS... >> >> Why did you feel the need to add this target? > > I am not a makefile expert, but this states that statmount_test_ns > needs to link with utils.c code. > > I copied it from overlayfs/Makefile. > > Is there a different way to express this build dependency? > Yes, but first I need to reload the kselftest build story back into my head. I *almost* remember the answer offhand, but not quite! I'll pull down your branch, just a sec. thanks, -- John Hubbard
