On Mon, May 05, 2025 at 10:38:29PM +0100, Al Viro wrote: > On Mon, May 05, 2025 at 12:55:34PM +0200, Jan Kara wrote: > > > if (!type) > > > return NULL; > > > - mnt = vfs_submount(mntpt, type, "tracefs", NULL); > > > + > > > + fc = fs_context_for_submount(type, mntpt); > > > + if (IS_ERR(fc)) > > > + return ERR_CAST(fc); > > > > Missing put_filesystem() here? > > Actually, I'd rather have it done unconditionally right after > fc_context_for_submount() - fs_context allocation grabs > a reference and it's held until put_fs_context, so... Just in case - that stuff is still on top of ->d_automount() calling conventions change; see viro/vfs.git#work.automount for both.
