I think this subject line here is left from an earlier version and doesn't quite seem to summarize what this patch is doing now? > +extern int xfs_configure_buftarg(struct xfs_buftarg *, unsigned int); Please drop the extern and spell out the parameter name while you're at it. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>