On Mon 28-04-25 21:50:50, alexjlzheng@xxxxxxxxx wrote:
> From: Jinliang Zheng <alexjlzheng@xxxxxxxxxxx>
>
> After commit 475d0db742e3 ("fs: Fix theoretical division by 0 in
> super_cache_scan()."), there's no need to plus one to prevent
> division by zero.
>
> Remove it to simplify the code.
>
> Signed-off-by: Jinliang Zheng <alexjlzheng@xxxxxxxxxxx>
Fair enough. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/super.c b/fs/super.c
> index 97a17f9d9023..6bbdb7e59a8d 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -201,7 +201,7 @@ static unsigned long super_cache_scan(struct shrinker *shrink,
>
> inodes = list_lru_shrink_count(&sb->s_inode_lru, sc);
> dentries = list_lru_shrink_count(&sb->s_dentry_lru, sc);
> - total_objects = dentries + inodes + fs_objects + 1;
> + total_objects = dentries + inodes + fs_objects;
> if (!total_objects)
> total_objects = 1;
>
> --
> 2.49.0
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
