Re: [PATCH] hfs: fix not erasing deleted b-tree node issue

[Johannes Thumshirn <Johannes.Thumshirn@xxxxxxx>]

On 29.04.25 03:16, Viacheslav Dubeyko wrote:
> Signed-off-by: Viacheslav Dubeyko <slava@xxxxxxxxxxx>
> ---
>   fs/hfs/bnode.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/fs/hfs/bnode.c b/fs/hfs/bnode.c
> index cb823a8a6ba9..c5eae7c418a1 100644
> --- a/fs/hfs/bnode.c
> +++ b/fs/hfs/bnode.c
> @@ -219,6 +219,8 @@ void hfs_bnode_unlink(struct hfs_bnode *node)
>   		tree->root = 0;
>   		tree->depth = 0;
>   	}
> +
> +	hfs_bnode_clear(node, 0, tree->node_size);
>   	set_bit(HFS_BNODE_DELETED, &node->flags);
>   }
>   

Hi Slava,

I've just checked HFS+ code and hfs_bnode_unlink() in fs/hfsplus/bnode.c 
is a copy of the fs/hfs/bnode.c one (maybe most of the file is so 
there's room for unification?). So I think the fix is needed there as well.

Byte,
	Johannes