Currently VMA allocation, freeing and duplication exist in kernel/fork.c, which is a violation of separation of concerns, and leaves these functions exposed to the rest of the kernel when they are in fact internal implementation details. Resolve this by moving this logic to mm, and making it internal to vma.c, vma.h. This also allows us, in future, to provide userland testing around this functionality. We additionally abstract dup_mmap() to mm, being careful to ensure kernel/fork.c acceses this via the mm internal header so it is not exposed elsewhere in the kernel. As part of this change, also abstract initial stack allocation performed in __bprm_mm_init() out of fs code into mm via the create_init_stack_vma(), as this code uses vm_area_alloc() and vm_area_free(). In order to allow for this, we must add code shared between nommu and mmu-enabled configurations in order to share VMA allocation, freeing and duplication code correctly while also keeping these functions available in userland VMA testing. This is achieved by adding a vma_init.c file which is also compiled by the userland tests. v2: * Moved vma init, alloc, free, dup functions to newly created vma_init.c function as per Suren, Liam. * Added MAINTAINERS entry for vma_init.c, added to Makefile. * Updated mmap_init() comment. * Propagated tags (thanks everyone!) * Added detach_free_vma() helper and correctly detached vmas in userland VMA test code. * Updated userland test code to also compile the vma_init.c file. * Corrected create_init_stack_vma() comment as per Suren. * Updated commit message as per Suren. v1: https://lore.kernel.org/all/cover.1745528282.git.lorenzo.stoakes@xxxxxxxxxx/ Lorenzo Stoakes (3): mm: abstract initial stack setup to mm subsystem mm: move dup_mmap() to mm mm: perform VMA allocation, freeing, duplication in mm MAINTAINERS | 1 + fs/exec.c | 51 +----- include/linux/mm.h | 2 + kernel/fork.c | 277 +------------------------------ mm/Makefile | 2 +- mm/internal.h | 2 + mm/mmap.c | 253 +++++++++++++++++++++++++++- mm/nommu.c | 12 +- mm/vma.h | 6 + mm/vma_init.c | 101 +++++++++++ tools/testing/vma/Makefile | 2 +- tools/testing/vma/vma.c | 26 ++- tools/testing/vma/vma_internal.h | 143 +++++++++++++--- 13 files changed, 511 insertions(+), 367 deletions(-) create mode 100644 mm/vma_init.c -- 2.49.0
