Re: [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Darrick J. Wong" <djwong@xxxxxxxxxx>
Subject: Re: [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 23 Apr 2025 17:46:15 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, John Garry <john.g.garry@xxxxxxxxxx>, brauner@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, jack@xxxxxxx, cem@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, dchinner@xxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ojaswin@xxxxxxxxxxxxx, ritesh.list@xxxxxxxxx, martin.petersen@xxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, catherine.hoang@xxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx
In-reply-to: <20250423151224.GC25675@frogsfrogsfrogs>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, Apr 23, 2025 at 08:12:24AM -0700, Darrick J. Wong wrote:
> I disagree, leaving the hardware awu_min/max in the buftarg makes more
> sense to me because the buftarg is our abstraction for a block device,
> and these fields describe the atomic write units that we can use with
> that block device.

Yeah.  If you want to keep it I'd suggest we go back to my earlier
suggestion.

References:
- [PATCH v8 00/15] large atomic writes for xfs
  - From: John Garry
- [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block
  - From: John Garry
- Re: [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block
  - From: Darrick J. Wong
- Re: [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block
  - From: John Garry
- Re: [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block
  - From: Christoph Hellwig
- Re: [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block
  - From: John Garry
- Re: [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block
  - From: Christoph Hellwig
- Re: [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block
  - From: Darrick J. Wong

Prev by Date: Re: [PATCH v8 11/15] xfs: commit CoW-based atomic writes atomically
Next by Date: [PATCH] ext4: Fix calculation of credits for extent tree modification
Previous by thread: Re: [PATCH v8 05/15] xfs: ignore HW which cannot atomic write a single block
Next by thread: [PATCH v8 04/15] xfs: rename xfs_inode_can_atomicwrite() -> xfs_inode_can_hw_atomicwrite()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]