Re: [PATCH] fs: move the bdex_statx call to vfs_getattr_nosec

[Christian Brauner <brauner@xxxxxxxxxx>]

On Tue, Apr 22, 2025 at 10:17:36AM +0200, hch wrote:
> On Tue, Apr 22, 2025 at 10:15:48AM +0200, Christian Brauner wrote:
> > > -	bdev = blkdev_get_no_open(backing_inode->i_rdev);
> > > +	if (!(request_mask & (STATX_DIOALIGN | STATX_WRITE_ATOMIC)))
> > > +		return;
> > 
> > This leaks the block device reference if blkdev_get_no_open() succeeds.
> > 
> > > +
> > > +	bdev = blkdev_get_no_open(d_backing_inode(path->dentry)->i_rdev);
> 
> The one removed by the patch above, or the one added after the check
> below? :)

Ah, I got confused by the inline diff.