On Tue 15-04-25 16:16:32, Davidlohr Bueso wrote:
> This is a path that allows for blocking as it does IO. Convert
> to the new nonatomic flavor to benefit from potential performance
> benefits and adapt in the future vs migration such that semantics
> are kept.
>
> Suggested-by: Jan Kara <jack@xxxxxxx>
> Signed-off-by: Davidlohr Bueso <dave@xxxxxxxxxxxx>
One nit below but either way feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
> diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c
> index f1b4b3e611cb..c7a9729dc9d0 100644
> --- a/fs/ocfs2/journal.c
> +++ b/fs/ocfs2/journal.c
> @@ -1249,7 +1249,7 @@ static int ocfs2_force_read_journal(struct inode *inode)
> }
>
> for (i = 0; i < p_blocks; i++, p_blkno++) {
> - bh = __find_get_block(osb->sb->s_bdev, p_blkno,
> + bh = __find_get_block_nonatomic(osb->sb->s_bdev, p_blkno,
This could be using sb_find_get_block_nonatomic().
> osb->sb->s_blocksize);
> /* block not cached. */
> if (!bh)
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
