On Mon, Apr 14, 2025 at 01:58:57PM +0800, Zorro Lang wrote: > On Sun, Apr 13, 2025 at 05:56:08PM -0400, Kent Overstreet wrote: > > I heavily use xfstests and look at the test results every day - I > > believe that would indicate L3. > > Glad to receive the response from bcachefs :) L3 means there're enough fs specific > test cases in tests/$FSTYP besides generic cases, e.g. tests/overlay, or f2fs (although > it only has a few currently, but it's increasing). Active support for existing tests, or writing new tests? To be blunt, fstests is not a great environment for writing tests, the 'golden master' model of pass/failure means debugging test failures is archaic. But those tests do get run and used, with active support. > > bcachefs specific tests are not generally in fstests beacuse there's > > lots of things that ktest can do that fstests can't, and I find it a bit > > more modern (i.e. tests that names, not numbers) > > ktest? linux/tools/testing/ktest/ ? I'm glad to learn about more test suites, > I run fstests and LTP and some others too, fstests can't cover everything :) > Hmm... about the names... fstests supports to append a name to the ID number, > but the developers (looks like) prefer using number only all the time, then > it become a "tradition" now. No, not that. Does anyone even use that thing? https://evilpiepirate.org/git/ktest.git/ It's a full CI - https://evilpiepirate.org/~testdashboard/ci > > > > > Not all tests are passing (and won't be for awhile), but the remaining > > stuff is non critical (i.e. fsync() error behaviour when the filesystem > > has been shutdown, or certain device removal tests where the behaviour > > could probably use some discussion. > > > > But if you find e.g. a configuration that produces a generic/388 pop, > > that would go to the top of the pile. > > > > (I do have a few patches to the tests for bcachefs in my tree that I > > really ought to get upstream). > > Sure, warm welcome your patches. And don't worry, you can send patch to > update the level part anytime when you think fstests supports becachefs > more :) > > Thanks, > Zorro > > > >