On Thu, Apr 10, 2025 at 07:45:28PM +0800, Zijun Hu wrote: > From: Zijun Hu <quic_zijuhu@xxxxxxxxxxx> > > Macro fsparam_u32hex() uses as type @fs_param_is_u32_hex which is > never defined. > > Fix by using @fs_param_is_u32 instead as fsparam_u32oct() does. > > Fixes: 328de5287b10 ("turn fs_param_is_... into functions") > Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx> > --- > include/linux/fs_parser.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/fs_parser.h b/include/linux/fs_parser.h > index 53e566efd5fd133d19e313e494b975612a227b77..ca76601d0bbdbaded76515cb6b2c06fa30127a06 100644 > --- a/include/linux/fs_parser.h > +++ b/include/linux/fs_parser.h > @@ -126,7 +126,7 @@ static inline bool fs_validate_description(const char *name, > #define fsparam_u32oct(NAME, OPT) \ > __fsparam(fs_param_is_u32, NAME, OPT, 0, (void *)8) > #define fsparam_u32hex(NAME, OPT) \ > - __fsparam(fs_param_is_u32_hex, NAME, OPT, 0, (void *)16) > + __fsparam(fs_param_is_u32, NAME, OPT, 0, (void *)16) Remove that define completely as it's unused. There's no point keeping dead code around.