On Wed, Apr 02, 2025 at 04:00:00PM +0100, Matthew Wilcox (Oracle) wrote: > Convert from an inefficient loop to the standard writeback iterator. Not for this patch but a follow on: we really need to improve the abstraction for using shmem for driver a bit. Drivers implementing their own writeback_iter based loop is a bad idea. Instead the code here in __shmem_writeback and the similar version in ttm need to be consolidated into a nicely abstracted highlevel API in shmem.c. Similarly for the mess these drivers cause by calling into the write_begin and write_end aops.